Skip to content

Conversation

@Picazsoo
Copy link
Contributor

@Picazsoo Picazsoo commented Feb 3, 2026

Spring declares that Http Interface annotations can also be used server-side for controller instantiation: https://docs.spring.io/spring-framework/reference/integration/rest-clients.html#rest-http-service-client

On the server side, an @controller class can implement the same interface to handle requests with @HttpExchange controller methods. In such case it makes sense to allow the bean validation option and thus annotate both the model and the api methods with jakarta.validation annotations.

I will add some unit tests in the coming days.

closes #22859

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Add Bean Validation support to the Spring HTTP Interface library (reactive and non‑reactive). The generator now respects useBeanValidation and performBeanValidation (both default to false). Fixes #22859.

  • New Features
    • Respect useBeanValidation and performBeanValidation in SpringCodegen for spring-http-interface, defaulting both to false when not set.
    • Generate @validated on interfaces when Bean Validation is enabled and Spring built-in validation is not used; add required validation imports.
    • Add sample configs for bean-validation variants and update CI to build them.

Written for commit b9cb91e. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][JavaSpring] Spring HTTP Interface library must support useBeanValidation

1 participant