[cpp-qt-client]Prefix signal argument types with namespace

[martonmiklos]

For reason see: https://github.com/KDE/clazy/blob/master/docs/checks/README-fully-qualified-moc-types.md

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

---

Summary by cubic

Fully qualify the on_execution_finished signal argument across cpp-qt-client to ensure proper moc type resolution in namespaced builds and satisfy clazy’s fully-qualified moc types check.

• Bug Fixes
  • Update HttpRequest.h.mustache to use on_execution_finished({{#cppNamespaceDeclarations}}{{this}}::{{/cppNamespaceDeclarations}}{{prefix}}HttpRequestWorker*).
  • Update generated sample headers to use on_execution_finished(test_namespace::PFXHttpRequestWorker*).

^{Written for commit 2d24534. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="modules/openapi-generator/src/main/resources/cpp-qt-client/HttpRequest.h.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/cpp-qt-client/HttpRequest.h.mustache:74">
P2: `{{this}}` is used outside the `cppNamespaceDeclarations` section, so it renders the root context instead of a namespace and produces invalid C++ type qualification.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[wing328]

thanks for the PR

please follow step 3 to update the samples

cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) @aminya (2025/05)

[aminya]

Was this tested to see if it solves the problem?

[MartinDelille]

I'm fine with this change. Would it be possible to run clazy on the CI ? I never managed to integrate clazy in my CI workflow but someone has maybe an idea ?

[martonmiklos]

I'm fine with this change. Would it be possible to run clazy on the CI ? I never managed to integrate clazy in my CI workflow but someone has maybe an idea ?

Yeah that would be helpful, as there are a few other things I found with it in the generated codes (what I am planning to fix and PR soon.)