Skip to content

Conversation

@cryos
Copy link
Member

@cryos cryos commented Apr 19, 2023

This hit me today where GetNumberOfTuples() returns vtkIdType but this templated function was using int which then overflows for big volumes.

This hit me today where GetNumberOfTuples() returns vtkIdType but this
templated function was using int which then overflows for big volumes.

Signed-off-by: Marcus D. Hanwell <mhanwell@bnl.gov>
@cryos cryos requested review from cjh1 and psavery April 19, 2023 20:49
@cryos
Copy link
Member Author

cryos commented Apr 19, 2023

I am looking at a subset of a 217GB reconstruction, a highly cropped version still caused this issue. I have my work cut out for me ;-)

Copy link
Contributor

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@psavery
Copy link
Contributor

psavery commented Apr 19, 2023

By the way, Mac is failing because tbb@2020 is no longer available (see #2282 where I tried to fix it but could not). So don't worry about that one.

@psavery
Copy link
Contributor

psavery commented Apr 19, 2023

I am looking at a subset of a 217GB reconstruction, a highly cropped version still caused this issue. I have my work cut out for me ;-)

That's a lot of data!

@cryos cryos merged commit 750c657 into OpenChemistry:master Apr 20, 2023
@cryos cryos deleted the int-overflow-convert branch April 20, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants