fix(projects): resolve nested button HTML validation error#687
fix(projects): resolve nested button HTML validation error#687nino-chavez wants to merge 2 commits intoOpenCut-app:mainfrom
Conversation
Changed the selection mode wrapper from <button> to <div role="button"> to prevent nested button elements when Checkbox (which renders as a button internally) is displayed inside the card. This fixes the HTML validation error: "<button> cannot contain a nested <button>" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Discovered another instance of nested <button> elements in the Select All row. Changed to <div role="button"> for consistency with the project card fix. Found by: Playwright E2E test for Issue OpenCut-app#675 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@nino-chavez is attempting to deploy a commit to the OpenCut OSS Team on Vercel. A member of the Team first needs to authorize it. |
👷 Deploy request for appcut pending review.Visit the deploys page to approve it
|
📝 WalkthroughWalkthroughFixed invalid HTML nesting where button elements contained nested buttons by replacing outer buttons with divs having role="button" and tabIndex={0}, preserving all interactive behavior and keyboard handling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add theme toggle to Projects page header (OpenCut-app#689) - Fix nested button HTML validation errors in header and hero (OpenCut-app#687) - Use asChild prop to render Links with button styles - Add ability to add multiple keyboard shortcuts per action (OpenCut-app#696) - New "+" button to add additional shortcuts - Replace mode only removes the specific key being edited - Right-click to remove a shortcut when multiple exist Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
<button>wrappers to<div role="button">in selection mode to avoid nesting buttons inside Checkbox (which renders as<button role="checkbox">)Related Issue
Fixes #675
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.