Skip to content

Report errors#375

Open
tomasjakubik wants to merge 6 commits intoOpenCyphal:masterfrom
tomasjakubik:report-errors
Open

Report errors#375
tomasjakubik wants to merge 6 commits intoOpenCyphal:masterfrom
tomasjakubik:report-errors

Conversation

@tomasjakubik
Copy link
Contributor

@tomasjakubik tomasjakubik commented Jan 19, 2026

Add hooks for errors

  • CAN controller errors via socketcan
  • when dropping a Tx frame

@tomasjakubik

This comment was marked as outdated.

Sign in to view
@coveralls
Copy link

coveralls commented Jan 20, 2026 •
edited
Loading

Coverage Status

coverage: 93.408% (-0.4%) from 93.785%
when pulling 9f0b95a on tomasjakubik:report-errors
into 9c97bd1 on OpenCyphal:master.

@tomasjakubik tomasjakubik force-pushed the report-errors branch 2 times, most recently from d53ad72 to d30391d Compare January 20, 2026 08:13
@tomasjakubik tomasjakubik marked this pull request as ready for review January 20, 2026 08:45
@tomasjakubik
Copy link
Contributor Author

tomasjakubik commented Jan 20, 2026 •
edited
Loading

@pavel-kirienko Please have a look when you have time.
I am not sure that the hook/callback architecture is the way to go, so feel free to suggest something better.
I don't like the coverage decrease, but I am not sure if we can test this code reasonably without hardware 🤷.

Those two fixes for libpcap and SOL_CAN_RAW might probably go to a minor patch version if needed.
edit: Libcap was fixed and the commit dropped.

@tomasjakubik
Remove deprecated from test dsdls
6879ddd 
Updated pydsdl does not like it. It was breaking many tests.
@tomasjakubik
Copy link
Contributor Author

tomasjakubik commented Jan 26, 2026

I think the missing setuptools came from the updated libpcap which changed the dependency.

As for the missing bpf_program it is probably also linked with changes in libpcap. I am looking into it.

pavel-kirienko
pavel-kirienko reviewed Jan 29, 2026
View reviewed changes
tests/dsdl/test_dsdl_namespace/if/C.1.0.dsdl
@@ -1,5 +1,4 @@
@union
@deprecated
Copy link
Member

@pavel-kirienko pavel-kirienko Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@tomasjakubik tomasjakubik Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing multiple tests. I think the deprecation is no longer allowed by newer pydsdl or nunavut or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasjakubik @coveralls @pavel-kirienko