Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I heavily relied on Claude Code to make these changes. The original code had a few whitespace inconsistencies which have been fixed, so it is best to hide whitespace-only changes when reviewing the diffs.
The
cyphal_udp.luadissector has been updated to match the proposed frame header, andz_cyphal_heartbeat.luahas been added via a subject-ID dissector table, which is used by the lower-level dissector to find which higher-level dissector to invoke next.The CAN dissector is not updated.
Related: https://forum.opencyphal.org/t/rfc-early-preview-of-cyphal-v1-1/2438