Open
Conversation
anthonyfok
approved these changes
May 6, 2022
Member
anthonyfok
left a comment
anthonyfok
left a comment
There was a problem hiding this comment.
Hi Damon! I'm very sorry for the late reply, as I have either missed or forgotten your request for review. (The gh dash extension helped me check for pending reviews.)
Your code for the readme-check.yml GitHub Actions workflow looks really good to me! Thank you for your great work!
| do | ||
| RESPONSE=`curl -i https://api.github.com/repos/OpenDRR/$REPO/contents/README.md --write-out "%{http_code}\n" --output /dev/null --silent` | ||
| FRESPONSE=`curl -i -H "Authorization: $TOKEN" https://api.github.com/repos/OpenDRR/$REPO/contents/LISEZMOI.md --write-out "%{http_code}\n" --output /dev/null --silent` | ||
| if [ $RESPONSE == 404 ] && [ $FRESPONSE == 404 ] |
Member
There was a problem hiding this comment.
I would suggest using double square brackets, i.e. [[ $RESPONSE == 404 ]] && [[ $FRESPONSE == 404 ]] as otherwise the variables need to be double-quoted. In ShellCheck's words: SC2086 (info): Double quote to prevent globbing and word splitting.
jvanulde
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github action to check all repos for README.md and LISEZMOI.md.