routing: fix support for default gateway#272
Open
ChrisMuc wants to merge 1 commit intoOpenFastPath:masterfrom
Open
routing: fix support for default gateway#272ChrisMuc wants to merge 1 commit intoOpenFastPath:masterfrom
ChrisMuc wants to merge 1 commit intoOpenFastPath:masterfrom
Conversation
Contributor
|
Hi @ChrisMuc, Sorry to bring the bad news but there are no active maintainers for this repo. Both Nokia and Enea have lost interest and stopped contributing. There is no one to review and merge the fixes. The 'default route' functionality is missing and I plan to implement it at some point in my own version of OFP. Best regards, |
cjsworld
added a commit
to cjsworld/ofp
that referenced
this pull request
Nov 25, 2022
cjsworld
added a commit
to cjsworld/ofp
that referenced
this pull request
Nov 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues #147 and #240 complain about a non working default gateway feature. I had the same issue and tried to find solutions.
Routes with a netmask of /1 or larger are working, wheres routes with a netmask of /0 are accepted but not used when it comes to selecting the next hop.
e.g.
0.0.0.0/1and128.0.0.0/1The proposed fix initializes
nh(i.e. next hop) withtree->root->data[0](i.e. mtrie leaf for 0.0.0.0) and resets this to NULL, if this is not a gateway (i.e.OFP_RTL_FLAGS_GATEWAYnot set).This way,
if (elem->masklen == 0) return nh;will return the default gateway instead of NULL.