Enable zstd compression format#640
Open
GilbertHan1011 wants to merge 4 commits intoOpenGene:masterfrom
Open
Conversation
bwlang
approved these changes
Jan 18, 2026
Contributor
bwlang
left a comment
bwlang
left a comment
There was a problem hiding this comment.
@sfchen I tested this locally. It compiled and worked as expected for reading zstd compressed inputs - including with larger files (10k reads). I also tested interleaved fastq.zst files successfully
I think it could be merged, maybe without the .gitignore modification.
.gitignore
Outdated
| *.html No newline at end of file | ||
| *.html | ||
|
|
||
| out/ No newline at end of file |
Contributor
There was a problem hiding this comment.
I think this is a local preference
Author
There was a problem hiding this comment.
Yes. This have been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zstdandard(zstd) is a compression algorithm with higher performance than zlib. This contribution enabled fastp to handle zstd format