minor text changes; issue #658 fix#659
Open
itsgoadsoul wants to merge 1 commit intoOpenGene:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added lines in README and docstring for no auto-detection in case of STDIN.
This should be a fix for the requested issue #658.
original issue:
"Running fastp from STDIN, whether interleaved paired data with --detect_adapter_for_pe, or on single-end data, runs with no error but outputs messages that auto-detection is disabled (example below). It would be helpful to note this behavior in the README and doc string."
Besides the Added line in the README and the added sentence in the cmd --help docstring, I removed the second Error-output from read2, by checking supportEvaluation instead of !supportEvaluation and an else.
Hope this is clear and helpful.