cmake: document options and set defaults for influential variables#5581
Open
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Open
cmake: document options and set defaults for influential variables#5581vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
Collaborator
|
Looks like your (or Claude's ?) change to system.cmake broke Cooperlake option handling, please check. |
Add documentation strings and defaults for CMake cache variables including TARGET, BINARY, threading options, vector extensions, memory tuning, and precision types. Treat empty string values as "not set" to allow auto-detection while keeping options visible in ccmake. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vtjnash
force-pushed
the
jn/cmake-docs
branch
from
4bb9754 to
4a585b1
Compare
Contributor
Author
|
A little bit of both of our fault. Claude wanted to re-write all the files to use the explicit |
Contributor
Author
|
Bump? Seems like everything passed (unless it got killed when CI ran out of time) now that I removed the unnecessary part of this change. |
Contributor
Author
|
bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
ccmakelist all of these values, by letting it know that they can be influential, and let the user know what they do. Adds documentation strings and defaults for CMake cache variables including TARGET, BINARY, threading options, vector extensions, memory tuning, and precision types. Treat empty string values as "not set" to allow auto-detection while keeping options visible in ccmake.🤖 Generated with Claude Code