build: Fix LIBNAMESUFFIX handling in CMake documentation#5583
Open
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Open
build: Fix LIBNAMESUFFIX handling in CMake documentation#5583vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
vtjnash wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
- Fix cmake/system.cmake: LIBPREFIX was incorrectly overwritten when LIBNAMESUFFIX was defined, losing both "lib" prefix and "openblas" - Fix Makefile.rule docs: typo used LIBNAMESUFFIX instead of LIBNAMEPREFIX - Fix Makefile.rule docs: removed misleading underscores from examples - Fix docs/build_system.md: removed incorrect claim about automatic underscore separator The implementation does not add an underscore before the suffix - users who want a separator should include it in their LIBNAMESUFFIX value (e.g., LIBNAMESUFFIX=_omp). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Bump? This looked like a pretty straightforward doc fix |
Contributor
Author
|
bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude analyzed the makefiles and noticed (and fixed) several bugs in the handling of LIBNAMESUFFIX relative to the Makefile implementation:
The implementation does not add an underscore before the suffix - users who want a separator should include it in their LIBNAMESUFFIX value (e.g., LIBNAMESUFFIX=_omp).
🤖 Generated with Claude Code