build: fix Makefile build with LLVM flang on macOS#5633
Open
cho-m wants to merge 1 commit intoOpenMathLib:developfrom
Open
build: fix Makefile build with LLVM flang on macOS#5633cho-m wants to merge 1 commit intoOpenMathLib:developfrom
cho-m wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake build has a workaround but Makefile still fails building with LLVM Flang:
This PR passes the options not found in
flang --helpdirectly to linker via-Wl.Only
-dynamiclibis not valid. Based onman ldandld64.lld --help, it seems-Wl,-dylibshould work for shared library. May need to confirm if-dynamiclibdoes anything else.An alternative could be to use CC instead of FC during linking similar to CMake workaround.