-
Notifications
You must be signed in to change notification settings - Fork 439
Fix flaky transformers_wav2vec2 test #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix flaky transformers_wav2vec2 test #1996
Conversation
6f37ce3 to
6d1c9c8
Compare
|
Do we know why this fixes the issue and why it started at some point? cc: @sssshhhhhh |
|
My guess, its behavior becomes non-deterministic when the thread count isn't explicitly set and different hardware triggered it. |
|
wav2vec with set threads already is still flaky tho. I guess it's some hardware thing |
|
Maybe it could change to jfk, I checked every diff <0.5 can swap and it won't change the output |
…sformers_wav2vec2bert
…est_transformers_wav2vec2bert" This reverts commit f7c71bd.
6d1c9c8 to
50a74ce
Compare
@jordimas |
|
Maybe let's check against both variations, "APOSSTEL" and "APOSSEL"? |
Revive
cpu_threadsintest_transformers_wav2vec2similar totest_transformers_wav2vec2bert.resolves #1997