init.d/net-online: Minor bug fix and minor feature addition #908
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
could you split this in two commits, one for the fix, and one for the tun/tap handling? and name both commits accordingly |
Contributor
Author
|
Certainly. But still one pull request? |
Member
|
one pull request, yes |
john-r-graham
force-pushed
the
net-online-tun-tap-support
branch
from
1b53e35 to
49eae02
Compare
Contributor
Author
|
Done as requested. |
The code that reads interface status from the sysfs had stderr redirection in the wrong order, which means that, in the event that the interface does not yet exist, the read will display an error message that was meant to be suppressed.
Added a single line that allows tun/tap interfaces to be properly handled. It
turns out that /sys/class/net/${interface}/operstate shows "unknown" for tun/tap
interfaces, not "up", which is the value that net-online depends on. So tun/tap
interfaces need minor special handling.
john-r-graham
force-pushed
the
net-online-tun-tap-support
branch
from
49eae02 to
01ba02e
Compare
Contributor
Author
|
Pushed again to correct a typo in a commit message. No code change. |
Member
|
thanks |
john-r-graham
added a commit
to john-r-graham/jrg-overlay
that referenced
this pull request
Oct 30, 2025
See pull request for details: OpenRC/openrc#908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that reads interface status from the sysfs had stderr redirection in the wrong order, which means that, in the event that the interface does not yet exist, the read will display an error message that was meant to be suppressed.
Also added a single line that allows tun/tap interfaces to be properly handled. It turns out that /sys/class/net/${interface}/operstate shows "unknown" for tun/tap interfaces, not "up", which is the value that net-online depends on. So tun/tap interfaces need minor special handling.