Open
Conversation
…ns and fixed a variable name.
…ved some warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running network_monitor.py on Ubuntu, it would crash while trying to create the usage text.
Solution
create_usagewas using global variablesIFSanddevicewhen they weren't yet declared, and usingdevicewhere it should have beenpcapy_device. The first commit was the minimal fix.The second commit sought to eliminate these global variables and clean up a couple warnings. Change summary:
get_ifs()method makesIFSvariable available to maincreate_usage()now takes IFS as an inputIFSrenamed toifs(PEP8)main()method so that main code executes in a local scope. This addressed shadowing issues with theifsvariable.create_usage()is now side-effect free and we're using less global variables!Tested
on Ubuntu. Verified docstring works and that network_monitor.py starts and accepts connections. I haven't figure out how to get Tornado on Windows yet so I can't test it there.