Support RSA_NO_PADDING signature requests from OpenSSL#22
Closed
selvanair wants to merge 1 commit intoOpenSC:masterfrom
Closed
Support RSA_NO_PADDING signature requests from OpenSSL#22selvanair wants to merge 1 commit intoOpenSC:masterfrom
selvanair wants to merge 1 commit intoOpenSC:masterfrom
Conversation
alonbl
reviewed
Apr 22, 2019
lib/pkcs11h-openssl.c
Outdated
| else if (padding == RSA_NO_PADDING) { | ||
| mech = CKM_RSA_X_509; | ||
| } | ||
| else { |
Member
There was a problem hiding this comment.
Can you please convert this to switch statement?
Member
There was a problem hiding this comment.
Can you please also sync __pkcs11h_openssl_rsa_dec?
Member
|
Please also rename patch title to: openssl: Support RSA_NO_PADDING padding Or something similar. Thanks! |
When PSS padding is in use, OpenSSL pre-pads the data and requests signature with padding=RSA_NO_PADDING. Handle this using CKM_RSA_X_509 as the mechanism. Signed-off-by: Selva Nair <selva.nair@gmail.com>
Contributor
Author
|
Changes:
|
Member
|
Thanks! |
|
Why was this PR closed? The issue is still present, and the patch works for me. |
Contributor
Author
|
It was committed to master in April see commit c192bb4 ... |
|
Sorry; I missed that somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PSS padding is in use, OpenSSL pre-pads the data and
requests signature with padding=RSA_NO_PADDING. Handle this
using CKM_RSA_X_509 as the mechanism.
Signed-off-by: Selva Nair selva.nair@gmail.com