[DO NOT MERGE] Support XCCDF Values containing newlines in Ansible Playbooks#2305
Draft
jan-cerny wants to merge 1 commit intoOpenSCAP:mainfrom
Draft
[DO NOT MERGE] Support XCCDF Values containing newlines in Ansible Playbooks#2305jan-cerny wants to merge 1 commit intoOpenSCAP:mainfrom
jan-cerny wants to merge 1 commit intoOpenSCAP:mainfrom
Conversation
When generating Ansible Playbooks from SCAP content, the values of XCCDF Values are extracted from Ansible code and added to the `vars` key in the generated Playbook. However, if the value contains newlines, the generated Playbook is invalid, because the inserted string isn't properly indented. This patch adds support for multi-line values. If the value will contain newlines, it will be indented and inserted as a YAML scalar block.
jan-cerny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating Ansible Playbooks from SCAP content, the values of XCCDF Values are extracted from Ansible code and added to the
varskey in the generated Playbook. However, if the value contains newlines, the generated Playbook is invalid, because the inserted string isn't properly indented. This patch adds support for multi-line values. If the value will contain newlines, it will be indented and inserted as a YAML scalar block.