fixed lines for wreckfest and added docker-compose that I am using#31
Open
raynfalldown wants to merge 3 commits intoOpenSourceLAN:masterfrom
Open
fixed lines for wreckfest and added docker-compose that I am using#31raynfalldown wants to merge 3 commits intoOpenSourceLAN:masterfrom
raynfalldown wants to merge 3 commits intoOpenSourceLAN:masterfrom
Conversation
Author
|
As an update to this, I was using ubuntu:18.04 locally since 16.04 is out of LTS at this point. I did not update the base image at the time of this original pull request. I have fixed that to make everything in my local env match the repo here. I also changed the sleep from 1s to 5s to help make sure the server starts correctly each time. |
Author
|
I noticed that you updated the base to 20.04 on the pax2022 branch, so I did the same on my local copy and rebuilt the images. The server is still working correctly on 20.04 with the changes that I have made in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR so any feedback is appreciated.
I spent some time to get your Wreckfest dockerfiles working because they were giving some errors as-is.
The wine/Dockerfile was modified with a command to remove the .fontconfig folder due to some corruption error messages when launching the server.
I fixed a typo for xvfb on wine/README.md.
I rearranged the wreckfest/Dockerfile a little. I had to add the
RUN winecfgcommand as the second part of the .fontconfig folder corruption that I mentioned above. I removed theUSER rootcommand because it didn't seem necessary.I added wreckfest/docker-compose.yml because I run my containers with docker-compose and figure others might as well. It is working correctly as of this writing. The version:3.0 is arbitrary.
wreckfest/start-wreckfest.sh adds
sleep 1sbecause there were some issues with the server not starting correctly otherwise. I also addedxvfb-runto the exec command to make the server actually run correctly.I hope this helps others who are running into issues with these dockerfiles. Again, I am open to feedback on this. I am not sure if the wine?Dockerfile is the correct place to remove the .fontconfig folder, but it has worked so far.
Thanks in advance.