Decode WebAuthn object from calldata buffers, with out-of-bound detection#191
Merged
Decode WebAuthn object from calldata buffers, with out-of-bound detection#191
Conversation
ernestognw
previously approved these changes
Jul 16, 2025
Member
ernestognw
left a comment
ernestognw
left a comment
There was a problem hiding this comment.
Small nit, but I like it overall. Thanks!
Comment on lines
+249
to
+250
| // Default result (optimistic) | ||
| success = true; |
Member
There was a problem hiding this comment.
Maybe it's fine to move this flag to the end? It will be kept in the stack anyway and returning at the end might save a DUP
ernestognw
reviewed
Jul 16, 2025
ernestognw
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by OpenZeppelin/openzeppelin-contracts#5400
and https://github.com/Vectorized/solady/blob/main/src/utils/WebAuthn.sol#L180-L211