fix: improve solhint custom rules and remove TODOs#5497
Closed
crStiv wants to merge 12 commits intoOpenZeppelin:masterfrom
crStiv:фф
Hidden character warning
The head ref may contain hidden characters: "\u0444\u0444"
Closed
fix: improve solhint custom rules and remove TODOs#5497crStiv wants to merge 12 commits intoOpenZeppelin:masterfrom crStiv:фф
crStiv wants to merge 12 commits intoOpenZeppelin:masterfrom
crStiv:фф
Conversation
|
Amxx
reviewed
Feb 12, 2025
scripts/solhint-custom/index.js
Outdated
|
|
||
| FunctionDefinition(node) { | ||
| // Skip constructor, function without a name (receive/fallback) and interface definitions | ||
| if (node.isConstructor || node.name == null || node.parent.kind === 'interface') { |
Collaborator
There was a problem hiding this comment.
NOTE: prettier rules say that receive and fallback function MUST be external. This creates a conflicts if they are virtual. This leaves us tree options:
- remove virtual from receive/fallback: bit no for me!
- change the prettier config
- (what I did here) skip the rule for receive and fallback functions.
Amxx
reviewed
Feb 12, 2025
Contributor
Author
|
@Amxx what are your thoughts on this PR altogether? I've made some changes to get rid of red failed checks, but they still fail |
3 tasks
Amxx
reviewed
Jun 5, 2025
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Collaborator
|
Closing in favor of #5794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the solhint custom rules by:
Both TODO comments have been addressed while maintaining the codebase's
coding standards and improving the overall code quality checks.