Refactor EnumerableSet and EnumerableMap to support more types#5558
Closed
Amxx wants to merge 7 commits intoOpenZeppelin:masterfrom
Closed
Refactor EnumerableSet and EnumerableMap to support more types#5558Amxx wants to merge 7 commits intoOpenZeppelin:masterfrom
Amxx wants to merge 7 commits intoOpenZeppelin:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 5fd07fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Mar 10, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors EnumerableSet and EnumerableMap generation:
Enumerable.opts.jsto generate all type descriptionsStringSetBytesSetBytesToUintMap(usefull for something like an ERC-7093 contract for guardian->weight)StringToStringMap(usefull for somthing like an ERC-7786 gateway/adaptor for caip2->address)PR Checklist
npx changeset add)Note
In 6.0 I'd remove the current design where the Bytes32Set and Bytes32ToBytes32Map are reused under the hood for other value types. This will allow us to reduce the number of variants of the generation functions.