Add Blockhash library following EIP-2935#5642
Merged
ernestognw merged 14 commits intoOpenZeppelin:masterfrom Apr 29, 2025
Merged
Add Blockhash library following EIP-2935#5642ernestognw merged 14 commits intoOpenZeppelin:masterfrom
ernestognw merged 14 commits intoOpenZeppelin:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 1c2fab1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
Tests are missing, perhaps there's a way to enable 2935 in either Foundry or Hardhat but requires some research before continue |
arr00
reviewed
Apr 21, 2025
arr00
reviewed
Apr 21, 2025
Member
Member
Author
|
Yeah I'm also trying to test in Foundry and it doesn't really work 😕 |
ernestognw
commented
Apr 22, 2025
arr00
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Blockhash library as per EIP-2935, extending access to historical block hashes beyond the standard 256-block limit.
- Updates the EVM version in foundry.toml from 'cancun' to 'prague' to support new EIP features.
- Adds a changeset entry detailing the Blockhash library feature.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| foundry.toml | Updated evm_version to 'prague' to reflect the new EIP-2935 support. |
| .changeset/wet-dodos-reply.md | Added changeset entry summarizing the Blockhash library feature. |
Files not reviewed (2)
- contracts/utils/Blockhash.sol: Language not supported
- test/utils/Blockhash.t.sol: Language not supported
arr00
previously approved these changes
Apr 29, 2025
arr00
approved these changes
Apr 29, 2025
Member
Author
|
Thanks for leading this @arr00 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5639
PR Checklist
npx changeset add)