Skip to content

Reorder cryptography folder#5711

Merged
ernestognw merged 9 commits intoOpenZeppelin:masterfrom
Amxx:feature/erc7913-light
Jun 4, 2025
Merged

Reorder cryptography folder#5711
ernestognw merged 9 commits intoOpenZeppelin:masterfrom
Amxx:feature/erc7913-light

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 3, 2025

The contracts/utils/cryptography folder is growing a lot betwen 5.3 and 5.4. IMO, it deserves some organisation to not confuse everything. We have the oportunity to organise stuff now. Once 5.4 is released, it will be too late.

sumarry:

  • new subfolder contracts/utils/cryptography/signers for Abstract signer and specialized signer. This includes ERC7739 and the new SignerERC7913
  • new subfolder contracts/utils/cryptography/verifier for verifier contracts (following ERC-7913)
  • isValidSignatureNow(bytes,bytes32,bytes) in Signature verifier (7913 variant of the 1271 version already in the library)

Alternative to #5659 for v5.4

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added this to the 5.4 milestone Jun 3, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025

⚠️ No Changeset found

Latest commit: 1afba85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested review from arr00, ernestognw and gonzaotc June 3, 2025 12:33
@Amxx Amxx force-pushed the feature/erc7913-light branch from f57830a to 99a74fb Compare June 3, 2025 13:03
@Amxx Amxx changed the title Reorder cryptography folder, and add ERC-7913 signer and verifiers Reorder cryptography folder Jun 3, 2025
gonzaotc
gonzaotc previously approved these changes Jun 3, 2025
Copy link
Contributor

@gonzaotc gonzaotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@ernestognw
Copy link
Member

Made some changes in how documentation is generated in community repo, so that we can have a subsection exclusive for cryptography.

I'll port them over here

ernestognw
ernestognw previously approved these changes Jun 3, 2025
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will try to reenable Netlify's preview before merging to check how it renders

@ernestognw
Copy link
Member

Here's how the API section looks in the docs. I also got the preview back (🥳 )

Captura de pantalla 2025-06-03 a la(s) 9 35 16 p m

I'd like to merge the Token > Common into just Token, but that would be breaking from an SEO perspective. I think the current version is well organized and keeps old documentation links

@ernestognw ernestognw merged commit f45e915 into OpenZeppelin:master Jun 4, 2025
18 checks passed
Copy link

@cshein45 cshein45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Movement

@Amxx Amxx deleted the feature/erc7913-light branch June 4, 2025 07:42
@Amxx
Copy link
Collaborator Author

Amxx commented Jun 4, 2025

@ernestognw

I'd like to merge the Token > Common into just Token

#5498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants