You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The contracts/utils/cryptography folder is growing a lot betwen 5.3 and 5.4. IMO, it deserves some organisation to not confuse everything. We have the oportunity to organise stuff now. Once 5.4 is released, it will be too late.
sumarry:
new subfolder contracts/utils/cryptography/signers for Abstract signer and specialized signer. This includes ERC7739 and the new SignerERC7913
new subfolder contracts/utils/cryptography/verifier for verifier contracts (following ERC-7913)
isValidSignatureNow(bytes,bytes32,bytes) in Signature verifier (7913 variant of the 1271 version already in the library)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Here's how the API section looks in the docs. I also got the preview back (🥳 )
I'd like to merge the Token > Common into just Token, but that would be breaking from an SEO perspective. I think the current version is well organized and keeps old documentation links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
contracts/utils/cryptographyfolder is growing a lot betwen 5.3 and 5.4. IMO, it deserves some organisation to not confuse everything. We have the oportunity to organise stuff now. Once 5.4 is released, it will be too late.sumarry:
contracts/utils/cryptography/signersfor Abstract signer and specialized signer. This includes ERC7739 and the new SignerERC7913contracts/utils/cryptography/verifierfor verifier contracts (following ERC-7913)isValidSignatureNow(bytes,bytes32,bytes)in Signature verifier (7913 variant of the 1271 version already in the library)Alternative to #5659 for v5.4
PR Checklist
npx changeset add)