Skip to content

Add ERC-165 detection for ERC6909TokenSupply and ERC6909Metadata#6247

Merged
ernestognw merged 4 commits intoOpenZeppelin:masterfrom
arr00:chore/6909-extensions-165
Dec 30, 2025
Merged

Add ERC-165 detection for ERC6909TokenSupply and ERC6909Metadata#6247
ernestognw merged 4 commits intoOpenZeppelin:masterfrom
arr00:chore/6909-extensions-165

Conversation

@arr00
Copy link
Member

@arr00 arr00 commented Dec 29, 2025

ERC-6909 defines three extensions which we implement. These extensions have their own intefaces but we didn't add ERC-165 detection for these interfaces.

#6246 flagged this issue and fixed it for ERC6909ContentURI. This PR fixes it for ERC6909TokenSupply and ERC6909Metadata.

We will keep the fix for ERC6909ContentURI seperate to ensure credit is given properly. There will only be one changeset for all the changes which will be part of this PR.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@arr00 arr00 requested a review from a team as a code owner December 29, 2025 09:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2025

⚠️ No Changeset found

Latest commit: 7b02ef0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arr00 arr00 changed the title Add ERC-165 detection for and Add ERC-165 detection for and ERC6909TokenSupply and ERC6909Metadata Dec 29, 2025
@arr00 arr00 changed the title Add ERC-165 detection for and ERC6909TokenSupply and ERC6909Metadata Add ERC-165 detection for ERC6909TokenSupply and ERC6909Metadata Dec 29, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Walkthrough

This pull request adds ERC165 interface detection support to two ERC6909 extensions. The ERC6909Metadata and ERC6909TokenSupply contracts now implement supportsInterface functions that advertise their respective interface identifiers while delegating to parent implementations. Corresponding test coverage has been added to verify interface support, and the interface behavior test utility has been updated with the new ERC6909Metadata and ERC6909TokenSupply interface signatures.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding ERC-165 detection for two ERC6909 extensions (ERC6909TokenSupply and ERC6909Metadata), which is the primary objective of the changeset.
Description check ✅ Passed The PR description clearly explains the purpose: adding ERC-165 detection for ERC6909TokenSupply and ERC6909Metadata extensions, referencing related issue #6246.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@arr00 arr00 requested a review from ernestognw December 29, 2025 09:17
@ernestognw ernestognw merged commit a83d9aa into OpenZeppelin:master Dec 30, 2025
21 checks passed
@Amxx Amxx added this to the 5.6 milestone Jan 7, 2026
Amxx pushed a commit that referenced this pull request Jan 8, 2026
…6247)

Co-authored-by: ernestognw <ernestognw@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants