Skip to content

test: add decodeBatch error case coverage for ERC7579Utils #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tr-Kalyan wants to merge 3 commits into
base: master
Choose a base branch
from
Open

test: add decodeBatch error case coverage for ERC7579Utils #6251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01eb334
test: add decodeBatch error case coverage for ERC7579Utils
tr-Kalyan Jan 1, 2026
a92865e
chore: add changeset for ERC7579Utils test coverage
tr-Kalyan Jan 1, 2026
f6c1d8d
test: add decodeBatch error case coverage
tr-Kalyan Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fruity-buttons-shine.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'openzeppelin-solidity': patch
---

test: add decodeBatch error case coverage for ERC7579Utils
50 changes: 50 additions & 0 deletions test/account/utils/draft-ERC7579Utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,56 @@ describe('ERC7579Utils', function () {
]);
});

describe('decodeBatch error cases', function () {
beforeEach(async function () {
Object.assign(this, await loadFixture(fixture));
});

it('reverts when executionCalldata is empty', async function () {
const emptyData = '0x';
await expect(this.utils.$decodeBatch(emptyData)).to.be.revertedWithCustomError(
this.utils,
'ERC7579DecodingError',
);
});

it('reverts when executionCalldata is too short', async function () {
const shortData = '0x' + '00'.repeat(16);
await expect(this.utils.$decodeBatch(shortData)).to.be.revertedWithCustomError(
this.utils,
'ERC7579DecodingError',
);
});

it('reverts when array offset points outside buffer', async function () {
const malformedData = ethers.toBeHex(0x100, 32);
await expect(this.utils.$decodeBatch(malformedData)).to.be.revertedWithCustomError(
this.utils,
'ERC7579DecodingError',
);
});

it('reverts when array length exceeds uint64 max', async function () {
const offsetData = ethers.toBeHex(32, 32);
const tooLargeLength = ethers.toBeHex(ethers.toBigInt('0xFFFFFFFFFFFFFFFF') + 1n, 32);
const malformedData = offsetData + tooLargeLength.slice(2);
await expect(this.utils.$decodeBatch(malformedData)).to.be.revertedWithCustomError(
this.utils,
'ERC7579DecodingError',
);
});

it('reverts when buffer too small for array element pointers', async function () {
const offsetData = ethers.toBeHex(32, 32);
const arrayLength = ethers.toBeHex(10, 32);
const malformedData = offsetData + arrayLength.slice(2);
await expect(this.utils.$decodeBatch(malformedData)).to.be.revertedWithCustomError(
this.utils,
'ERC7579DecodingError',
);
});
});

describe('global', function () {
describe('eqCallTypeGlobal', function () {
it('returns true if both call types are equal', async function () {
Expand Down
Loading