perf: short-circuit TrieProof.verify on traversal error

[Fibonacci747]

PR Checklist

Reordered the condition in TrieProof.verify so that it first checks whether tryTraverse finished with NO_ERROR before calling Bytes.equal on the returned value. This preserves the existing behavior while avoiding unnecessary keccak256 computations for invalid proofs, making verification slightly cheaper in the common failure path.

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8711691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request modifies the verify function in contracts/utils/cryptography/TrieProof.sol by reordering the conditions in its return statement. The function now evaluates whether err == ProofError.NO_ERROR before comparing processedValue to value. Both conditions must still be true for the function to return true. The change affects the order of evaluation but does not alter the logical outcome or error handling behavior.

Possibly related PRs

• Add TrieProof library #5826: Introduced the TrieProof.verify implementation that is directly modified by this PR's condition reordering.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: reordering conditions in TrieProof.verify to short-circuit on error, which is a performance optimization.
Description check	✅ Passed	The description is directly related to the changeset, explaining the condition reordering in TrieProof.verify and its performance benefits for invalid proofs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1004347 and 8711691.

📒 Files selected for processing (1)

• contracts/utils/cryptography/TrieProof.sol

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: slither
• GitHub Check: tests-foundry
• GitHub Check: tests-upgradeable
• GitHub Check: coverage
• GitHub Check: halmos

🔇 Additional comments (1)

contracts/utils/cryptography/TrieProof.sol (1)

69-77: LGTM! Valid short-circuit optimization.

Reordering to check err == ProofError.NO_ERROR before processedValue.equal(value) leverages short-circuit evaluation. The cheap enum comparison (~3 gas) now gates the expensive Bytes.equal call (which involves keccak256), saving gas on invalid proofs without changing the semantic result.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}