Skip to content

Improve consistency of numerlic literals in ERC7579Utils#6345

Merged
Amxx merged 2 commits intoOpenZeppelin:masterfrom
ernestognw:audit/n-04
Feb 12, 2026
Merged

Improve consistency of numerlic literals in ERC7579Utils#6345
Amxx merged 2 commits intoOpenZeppelin:masterfrom
ernestognw:audit/n-04

Conversation

@ernestognw
Copy link
Member

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw requested a review from a team as a code owner February 11, 2026 04:09
@openzeppelin-security-agent
Copy link

The latest updates on your security scan. Learn more about OpenZeppelin Platform.

Project Scan Issues Details Updated
Openzeppelin Contracts 🟡 Queued View Feb 11, 2026, 4:09 AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

⚠️ No Changeset found

Latest commit: 6cef937

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Walkthrough

This change modifies the decoding functions decodeSingle and decodeDelegate in the ERC7579Utils contract. Both functions have been updated to derive the target address from the full 20-byte prefix of the calldata using bytes20(executionCalldata), with adjustments to subsequent data slicing offsets. In decodeDelegate, the callData now starts at offset 20 instead of a different position. The overall functionality remains functionally equivalent, with no changes to public function signatures.

Suggested labels

ignore-changeset

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is a template with unchecked checklist items and no substantive details about the actual changes. While it references ERC7579Utils through the PR objectives, the description itself lacks meaningful information about the changeset. Provide a detailed description of the changes made, the rationale for improving consistency of numeric literals, and which numeric literals were modified.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions improving consistency of numeric literals in ERC7579Utils, which aligns with the changeset's focus on correctness normalization in decoding functions. However, the title uses 'numerlic' which appears to be a typo for 'numeric'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx added this to the 5.6 milestone Feb 11, 2026
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw requested a review from a team February 11, 2026 20:40
@Amxx Amxx merged commit 5dcb3bc into OpenZeppelin:master Feb 12, 2026
21 checks passed
Amxx added a commit that referenced this pull request Feb 12, 2026
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants