Skip to content

Add more tests of optional proof elements for inlined nodes#6379

Merged
Amxx merged 1 commit intoOpenZeppelin:masterfrom
Amxx:testing/trieproof-optional-testing-expanded
Feb 27, 2026
Merged

Add more tests of optional proof elements for inlined nodes#6379
Amxx merged 1 commit intoOpenZeppelin:masterfrom
Amxx:testing/trieproof-optional-testing-expanded

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 27, 2026

  • Tests

@Amxx Amxx requested a review from ernestognw February 27, 2026 19:51
@Amxx Amxx added the tests Test suite and helpers. label Feb 27, 2026
@Amxx Amxx requested a review from a team as a code owner February 27, 2026 19:51
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

⚠️ No Changeset found

Latest commit: a5209dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bebe85f and a5209dc.

📒 Files selected for processing (1)
  • test/utils/cryptography/TrieProof.test.js

Walkthrough

The pull request modifies test cases in TrieProof.test.js to enhance verification of trie proof structures. The changes add validation that full proofs match expected node counts and replace a single commented-out compression verification approach with explicit checks against multiple partial proof configurations. For both inline-extension and inline-extension-in-branch test cases, three distinct partial proof variations are introduced to validate different node combinations within the proof structure.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding tests for optional proof elements related to inlined nodes in TrieProof.
Description check ✅ Passed The description relates to the changeset by indicating tests were added, which aligns with the pull request's objective and the file modifications shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@Amxx Amxx merged commit 843ede2 into OpenZeppelin:master Feb 27, 2026
24 checks passed
@Amxx Amxx deleted the testing/trieproof-optional-testing-expanded branch February 27, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-changeset tests Test suite and helpers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants