Skip to content

Commit d89af95

Browse files
OpenarlOpenarl
committed
Merge remote-tracking branch 'origin/dev'
2 parents 8a7b66d + b7b916f commit d89af95

File tree

5 files changed

+53
-31
lines changed

5 files changed

+53
-31
lines changed

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
### 1.4.123 - 2019/01/02
2+
* Fixed issue causing Configuration tab options to sometimes fail to appear when appropriate
3+
* Fixed error when adding crafted modifiers to items
4+
15
### 1.4.122 - 2019/01/01
26
* Updated the crafting bench options for 3.5
37
* Added support for most of the new craft modifiers

‎Data/3_0/ModMaster.lua‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -636,12 +636,12 @@ return {
636636
{ type = "Suffix", affix = "of Riker", "(8-10)% increased Fire Damage", "(8-10)% increased Lightning Damage", statOrder = { 498, 514 }, level = 25, group = "IncreasedFireAndLightningDamage", types = { ["Ring"] = true, }, },
637637
{ type = "Suffix", affix = "of Riker", "(11-13)% increased Fire Damage", "(11-13)% increased Lightning Damage", statOrder = { 498, 514 }, level = 50, group = "IncreasedFireAndLightningDamage", types = { ["Ring"] = true, }, },
638638
{ type = "Suffix", affix = "of Riker", "(14-16)% increased Fire Damage", "(14-16)% increased Lightning Damage", statOrder = { 498, 514 }, level = 75, group = "IncreasedFireAndLightningDamage", types = { ["Ring"] = true, }, },
639-
{ type = "Suffix", affix = "of the Order", "3% of Life Regenerated per second during Flask Effect", statOrder = { 3991 }, level = 1, group = "LocalFlaskLifeRegenerationPerMinuteDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
640-
{ type = "Suffix", affix = "of the Order", "(8-12)% increased Movement Speed during Flask effect", "50% Chance to avoid being Stunned during Flask Effect", statOrder = { 351, 3986 }, level = 1, group = "LocalFlaskAvoidStunChanceAndMovementSpeedDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
641-
{ type = "Suffix", affix = "of the Order", "(20-25)% reduced Mana Cost of Skills during Flask Effect", statOrder = { 366 }, level = 1, group = "LocalFlaskSkillManaCostDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
642-
{ type = "Suffix", affix = "of the Order", "(20-30)% increased Rarity of Items found during Flask Effect", statOrder = { 3989 }, level = 1, group = "LocalFlaskItemFoundRarityDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
643-
{ type = "Suffix", affix = "of the Order", "(60-80)% increased Critical Strike Chance during Flask Effect", statOrder = { 3987 }, level = 1, group = "LocalFlaskCriticalStrikeChanceDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
644-
{ type = "Suffix", affix = "of the Order", "15% of Damage Taken from Hits is Leeched as Life during Flask Effect", statOrder = { 3990 }, level = 1, group = "LocalFlaskLifeLeechOnDamageTakenPermyriadDuringFlaskEffect", types = { ["Flask:Life"] = true, ["Flask:Mana"] = true, ["Flask:Hybrid"] = true, ["Flask:Utility"] = true, ["Flask:Utility"] = true, }, },
639+
{ type = "Suffix", affix = "of the Order", "3% of Life Regenerated per second during Flask Effect", statOrder = { 3991 }, level = 1, group = "LocalFlaskLifeRegenerationPerMinuteDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
640+
{ type = "Suffix", affix = "of the Order", "(8-12)% increased Movement Speed during Flask effect", "50% Chance to avoid being Stunned during Flask Effect", statOrder = { 351, 3986 }, level = 1, group = "LocalFlaskAvoidStunChanceAndMovementSpeedDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
641+
{ type = "Suffix", affix = "of the Order", "(20-25)% reduced Mana Cost of Skills during Flask Effect", statOrder = { 366 }, level = 1, group = "LocalFlaskSkillManaCostDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
642+
{ type = "Suffix", affix = "of the Order", "(20-30)% increased Rarity of Items found during Flask Effect", statOrder = { 3989 }, level = 1, group = "LocalFlaskItemFoundRarityDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
643+
{ type = "Suffix", affix = "of the Order", "(60-80)% increased Critical Strike Chance during Flask Effect", statOrder = { 3987 }, level = 1, group = "LocalFlaskCriticalStrikeChanceDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
644+
{ type = "Suffix", affix = "of the Order", "15% of Damage Taken from Hits is Leeched as Life during Flask Effect", statOrder = { 3990 }, level = 1, group = "LocalFlaskLifeLeechOnDamageTakenPermyriadDuringFlaskEffect", types = { ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, ["Flask"] = true, }, },
645645
{ type = "Suffix", affix = "of the Order", "(8-10)% increased Attack Speed", "+(7-12)% to Quality", statOrder = { 546, 3996 }, level = 1, group = "IncreasedAttackSpeed", types = { ["Dagger"] = true, ["One Handed Axe"] = true, ["One Handed Mace"] = true, ["One Handed Sword"] = true, ["Claw"] = true, ["Sceptre"] = true, ["Thrusting One Handed Sword"] = true, ["Wand"] = true, ["Two Handed Axe"] = true, ["Two Handed Mace"] = true, ["Two Handed Sword"] = true, ["Staff"] = true, ["Bow"] = true, }, },
646646
{ type = "Suffix", affix = "of the Order", "(13-16)% increased Attack Speed", "+(13-18)% to Quality", statOrder = { 546, 3996 }, level = 75, group = "IncreasedAttackSpeed", types = { ["Dagger"] = true, ["One Handed Axe"] = true, ["One Handed Mace"] = true, ["One Handed Sword"] = true, ["Claw"] = true, ["Sceptre"] = true, ["Thrusting One Handed Sword"] = true, ["Two Handed Axe"] = true, ["Two Handed Mace"] = true, ["Two Handed Sword"] = true, ["Staff"] = true, }, },
647647
{ type = "Suffix", affix = "of the Order", "(15-20)% increased Critical Strike Chance", "+(7-12)% to Quality", statOrder = { 595, 3996 }, level = 1, group = "CriticalStrikeChanceIncrease", types = { ["Dagger"] = true, ["One Handed Axe"] = true, ["One Handed Mace"] = true, ["One Handed Sword"] = true, ["Claw"] = true, ["Sceptre"] = true, ["Thrusting One Handed Sword"] = true, ["Wand"] = true, ["Two Handed Axe"] = true, ["Two Handed Mace"] = true, ["Two Handed Sword"] = true, ["Staff"] = true, ["Bow"] = true, }, },

‎Modules/Calcs.lua‎

Lines changed: 36 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -184,33 +184,48 @@ function calcs.buildOutput(build, mode)
184184
addMult(out, tag.var, mod)
185185
end
186186
end
187+
local function addModTags(mod)
188+
for _, tag in ipairs(mod) do
189+
if tag.type == "IgnoreCond" then
190+
break
191+
elseif tag.type == "Condition" then
192+
if actor == env.player then
193+
addCondTag(env.conditionsUsed, tag, mod)
194+
else
195+
addCondTag(env.minionConditionsUsed, tag, mod)
196+
end
197+
elseif tag.type == "ActorCondition" and tag.actor == "enemy" then
198+
addCondTag(env.enemyConditionsUsed, tag, mod)
199+
elseif tag.type == "Multiplier" or tag.type == "MultiplierThreshold" then
200+
if not tag.actor then
201+
if actor == env.player then
202+
addMultTag(env.multipliersUsed, tag, mod)
203+
end
204+
elseif tag.actor == "enemy" then
205+
addMultTag(env.enemyMultipliersUsed, tag, mod)
206+
end
207+
end
208+
end
209+
end
187210
for _, actor in ipairs({env.player, env.minion}) do
188211
for modName, modList in pairs(actor.modDB.mods) do
189212
for _, mod in ipairs(modList) do
190-
for _, tag in ipairs(mod) do
191-
if tag.type == "IgnoreCond" then
192-
break
193-
elseif tag.type == "Condition" then
194-
if actor == env.player then
195-
addCondTag(env.conditionsUsed, tag, mod)
196-
else
197-
addCondTag(env.minionConditionsUsed, tag, mod)
198-
end
199-
elseif tag.type == "ActorCondition" and tag.actor == "enemy" then
200-
addCondTag(env.enemyConditionsUsed, tag, mod)
201-
elseif tag.type == "Multiplier" or tag.type == "MultiplierThreshold" then
202-
if not tag.actor then
203-
if actor == env.player then
204-
addMultTag(env.multipliersUsed, tag, mod)
205-
end
206-
elseif tag.actor == "enemy" then
207-
addMultTag(env.enemyMultipliersUsed, tag, mod)
208-
end
209-
end
210-
end
213+
addModTags(mod)
211214
end
212215
end
213216
end
217+
for _, activeSkill in pairs(env.activeSkillList) do
218+
for _, mod in ipairs(activeSkill.skillModList) do
219+
addModTags(mod)
220+
end
221+
if activeSkill.minion then
222+
for _, activeSkill in pairs(activeSkill.minion.activeSkillList) do
223+
for _, mod in ipairs(activeSkill.skillModList) do
224+
addModTags(mod)
225+
end
226+
end
227+
end
228+
end
214229
for modName, modList in pairs(env.enemyDB.mods) do
215230
for _, mod in ipairs(modList) do
216231
for _, tag in ipairs(mod) do

‎changelog.txt‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
VERSION[1.4.123][2019/01/02]
2+
* Fixed issue causing Configuration tab options to sometimes fail to appear when appropriate
3+
* Fixed error when adding crafted modifiers to items
14
VERSION[1.4.122][2019/01/01]
25
* Updated the crafting bench options for 3.5
36
* Added support for most of the new craft modifiers

‎manifest.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<PoBVersion>
3-
<Version number="1.4.122"/>
3+
<Version number="1.4.123"/>
44
<Source part="program" url="https://raw.githubusercontent.com/Openarl/PathOfBuilding/{branch}/"/>
55
<Source part="tree" url="https://raw.githubusercontent.com/Openarl/PathOfBuilding/{branch}/tree.zip"/>
66
<Source url="https://raw.githubusercontent.com/Openarl/PathOfBuilding/{branch}/runtime-win32.zip" part="runtime" platform="win32"/>
77
<File sha1="74cd89091c4db01f0673217a5bd0927f232391e2" name="Launch.lua" part="program"/>
88
<File sha1="72b9bea1871e94a643e4471fd84bbedbc7810336" name="UpdateCheck.lua" part="program"/>
99
<File sha1="4f17937f2b37784e169a3792b235f2a0a3961e61" name="UpdateApply.lua" part="program"/>
10-
<File sha1="b3377828e20c4a55281c014c20f51cd550ca7689" name="changelog.txt" part="program"/>
10+
<File sha1="06597972da4ebbdb5e851e116fd1aa76f1760d8a" name="changelog.txt" part="program"/>
1111
<File sha1="b093a2709f30c1f83ce5ba9df88c80f22c1beb4a" name="Classes/BuildListControl.lua" part="program"/>
1212
<File sha1="16fc5eaa04cc14b2022f6705a12717935454dab0" name="Classes/ButtonControl.lua" part="program"/>
1313
<File sha1="a1c463f3329010e551700693296e998c8c2acd59" name="Classes/CalcBreakdownControl.lua" part="program"/>
@@ -62,7 +62,7 @@
6262
<File sha1="997c4bd005a38b8789c515397e15268253753722" name="Modules/CalcOffence-2_6.lua" part="program"/>
6363
<File sha1="96475faacacaf28f72682821e931e8ce6a4a1590" name="Modules/CalcOffence-3_0.lua" part="program"/>
6464
<File sha1="be37d5a67290e76ac997118af7d55bf947a7f81e" name="Modules/CalcPerform.lua" part="program"/>
65-
<File sha1="82e0199bb0f9d23e8b3d931f4095b8111d0e4170" name="Modules/Calcs.lua" part="program"/>
65+
<File sha1="c302345ed78c57863c991091936fd2fb842c4e68" name="Modules/Calcs.lua" part="program"/>
6666
<File sha1="32da2a949a5fe0ab10d54078a96caff0dccb5f3f" name="Modules/CalcSections-2_6.lua" part="program"/>
6767
<File sha1="f4757b7b290dc6e2f3e4c2b47f618cdd6184e893" name="Modules/CalcSections-3_0.lua" part="program"/>
6868
<File sha1="17b1facd712878bf4fc866e575748d42594d55a4" name="Modules/CalcSetup.lua" part="program"/>
@@ -157,7 +157,7 @@
157157
<File sha1="56d2d437d5b83e4ea5d422c2e09b4365d39db52c" name="Data/3_0/ModItem.lua" part="program"/>
158158
<File sha1="5729c201cc5be380557e576d35eded455ad7b1a0" name="Data/3_0/ModJewel.lua" part="program"/>
159159
<File sha1="1afaad3922511d410e96117c4925f15efa53f374" name="Data/3_0/ModJewelAbyss.lua" part="program"/>
160-
<File sha1="5ea53e890e8756c6b390203b4754bda8f74c10cb" name="Data/3_0/ModMaster.lua" part="program"/>
160+
<File sha1="bbbc1cb2129cd447cdaf8e4a340ae56e1828651c" name="Data/3_0/ModMaster.lua" part="program"/>
161161
<File sha1="16eb3b62d39e511c4de4efd0be461b5fe6af9924" name="Data/3_0/Rares.lua" part="program"/>
162162
<File sha1="3148ac90731103c7e0229f8ad6d2d40e5a8b4e1e" name="Data/3_0/SkillStatMap.lua" part="program"/>
163163
<File sha1="961566101bd0fc3964df5a8885b7c30a574387b4" name="Data/3_0/Spectres.lua" part="program"/>

0 commit comments

Comments
 (0)