Return error code if goad.sh process fails#454
Open
carlmon wants to merge 1 commit intoOrange-Cyberdefense:mainfrom
Open
Return error code if goad.sh process fails#454carlmon wants to merge 1 commit intoOrange-Cyberdefense:mainfrom
carlmon wants to merge 1 commit intoOrange-Cyberdefense:mainfrom
Conversation
suas-er
approved these changes
Oct 10, 2025
suas-er
left a comment
suas-er
left a comment
There was a problem hiding this comment.
just changed error code return. all valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to run GOAD deployment on a pipeline, but errors get swallowed so the pipeline cannot tell if it failed. This change just provides an error state if goad.sh or goad.py fails.