Open
Conversation
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
coxipi
commented
Feb 19, 2026
|
|
||
| def parametric_pdf( | ||
| p: xr.DataArray, | ||
| x: xr.DataArray | float | Sequence[float], |
Contributor
Author
There was a problem hiding this comment.
I think a DataArray makes sense here, so I can assign units with it. Do you agree? I could also change parametric_cdf in this way
coxipi
commented
Feb 19, 2026
| dist = get_dist(dist or p.attrs["scipy_dist"]) | ||
|
|
||
| data = xr.apply_ufunc( | ||
| lambda x, p: dist.pdf(x, *p), |
Contributor
Author
There was a problem hiding this comment.
what do we think of in-line lambda functions? I'm guessing this would not pass on the council ...
Collaborator
There was a problem hiding this comment.
We can make exceptions.
Simple functions are better than more complex ones; If it's easily read/understood, I don't see a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
xclim.indices.stats.parametric_pdfDoes this PR introduce a breaking change?
Other information: