Skip to content

Adress pytest socketblocked exception issues#2324

Merged
Zeitsperre merged 3 commits intomainfrom
support-socket-blocked
Feb 17, 2026
Merged

Adress pytest socketblocked exception issues#2324
Zeitsperre merged 3 commits intomainfrom
support-socket-blocked

Conversation

@Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Feb 17, 2026

Pull Request Checklist:

What kind of change does this PR introduce?

  • Sets SocketBlockedError to a subset of the Exception class, so that if ever it is encountered while pytest-socket is not installed (e.g. in downstream libraries), it doesn't error out during failed HTTP requests

Does this PR introduce a breaking change?

No.

Other information:

This should make it so that downstream libraries do not require pytest-socket, but can still make use of it if they wish to.

Credit for this solution is owed to @aulemahal.

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre added this to the v0.61.0 milestone Feb 17, 2026
@Zeitsperre Zeitsperre requested a review from aulemahal February 17, 2026 15:55
@Zeitsperre Zeitsperre self-assigned this Feb 17, 2026
@Zeitsperre Zeitsperre added the bug Something isn't working label Feb 17, 2026
@github-actions github-actions bot added the approved Approved for additional tests label Feb 17, 2026
@Zeitsperre
Copy link
Collaborator Author

Zeitsperre commented Feb 17, 2026

This PR needs fixes to deal with the new xsdba documentation structure. Sending along a PR soon.

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre enabled auto-merge February 17, 2026 21:08
@Zeitsperre Zeitsperre merged commit 602dc0a into main Feb 17, 2026
21 checks passed
@Zeitsperre Zeitsperre deleted the support-socket-blocked branch February 17, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved for additional tests bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nimbus.fetch raises misleading error when pytest-socket is not installed

2 participants

Comments