Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates package configurations to version 0.0.4 across multiple packaging systems (AUR, DEB, Snap, RPM) as part of a new release cycle.
- Version bumps from 0.0.3 to 0.0.4 across all packaging formats
- Updated checksums and build configurations for the new release
- Added new build scripts and cleaned up packaging workflows
Reviewed Changes
Copilot reviewed 20 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/snap/snapcraft.yaml | Updated to v0.0.4 with new binary checksum and cleaned up comments |
| pkg/snap/org.prasmoid.prasmoid.metainfo.xml | Added v0.0.4 release entry |
| pkg/snap/BUILD | New build script for snap packaging |
| pkg/snap/.gitignore | Added ignore pattern for snap files |
| pkg/rpm/prasmoid.spec | Updated to v0.0.4 and commented out build customizations |
| pkg/rpm/README | Removed old build documentation |
| pkg/rpm/BUILD | New build script for RPM packaging |
| pkg/rpm/.gitignore | Added ignore patterns for RPM artifacts |
| pkg/deb/prasmoid_0.0.4-1.dsc | Updated source control file with new version and checksums |
| pkg/deb/prasmoid/debian/rules | Removed custom install overrides |
| pkg/deb/prasmoid/debian/pbuilderhook.d/C10shell | Minor formatting improvement to shell hook |
| pkg/deb/prasmoid/debian/control | Updated dependencies and description |
| pkg/deb/prasmoid/debian/changelog | Added changelog entry for v0.0.4 |
| pkg/deb/prasmoid/debian/README | Removed old build documentation |
| pkg/deb/prasmoid/debian/.gitignore | Added config file ignore pattern |
| pkg/deb/BUILD | New build script for DEB packaging |
| pkg/aur/PKGBUILD.binonly | Removed binary-only package build |
| pkg/aur/PKGBUILD | Updated to v0.0.4 with new Go version requirement and build path |
| pkg/aur/BUILD | New build script for AUR packaging |
| pkg/.gitignore | Added log file ignore pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| -mod=readonly \ | ||
| -modcacherw \ | ||
| -ldflags "-s -w -X github.com/PRASSamin/prasmoid/internal.Version={pkgver}" -o prasmoid ./src | ||
| -ldflags "-s -w -X github.com/PRASSamin/prasmoid/internal.Version=${pkgver}" -o prasmoid . |
There was a problem hiding this comment.
The ldflags string contains unescaped variable substitution. The ${pkgver} should be $pkgver or the entire string should use double quotes to allow variable expansion.
Suggested change
| -ldflags "-s -w -X github.com/PRASSamin/prasmoid/internal.Version=${pkgver}" -o prasmoid . | |
| -ldflags "-s -w -X github.com/PRASSamin/prasmoid/internal.Version=$pkgver" -o prasmoid . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AUR and PPA are live but i'm having issues with the snap and rpm that I'm still working on: