Skip to content

AMM-2164 add config for unix environments#91

Merged
drtechie merged 1 commit intomainfrom
docker-properties
Feb 5, 2026
Merged

AMM-2164 add config for unix environments#91
drtechie merged 1 commit intomainfrom
docker-properties

Conversation

@drtechie
Copy link
Member

@drtechie drtechie commented Feb 5, 2026

📋 Description

JIRA ID: AMM-2164

Add properties file for UNIX deployments.


✅ Type of Change

  • ⚙️ Config change (configuration file or build script updates)

Summary by CodeRabbit

  • Chores
    • Added environment variable-based database connection configurations to support flexible multi-database deployment across different environments.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

A new properties file is introduced containing Spring Boot datasource configurations for Docker environments. The file defines multiple datasources with environment variable references for connection URLs, usernames, and passwords, all using MySQL JDBC drivers.

Changes

Cohort / File(s) Summary
Docker Datasource Configuration
src/main/environment/common_docker.properties
Adds Spring Boot datasource configurations for five databases (db_iemr, dbidentity, dbreporting, db1097identity) with environment variable-driven credentials and MySQL JDBC driver settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A Docker home, so neat and fine,
Five datasources, now aligned,
With MySQL threads and env vars bright,
Configuration flows just right! 🏠

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'AMM-2164 add config for unix environments' accurately describes the main change—adding configuration for Unix environments—and matches the file additions in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docker-properties

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

@drtechie
Copy link
Member Author

drtechie commented Feb 5, 2026

@sac2kadam I am merging this in interest of time.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/main/environment/common_docker.properties`:
- Around line 20-22: The db1097identity datasource properties use the wrong
environment variable names for credentials; change the values for
spring.datasource.db1097identity.username and
spring.datasource.db1097identity.password to reference
DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD respectively
so they match the JDBC URL (DATABASE_1097_IDENTITY_URL) and keep db1097identity
credentials isolated from the generic dbidentity variables.

Comment on lines +20 to +22
spring.datasource.db1097identity.jdbc-url=${DATABASE_1097_IDENTITY_URL}
spring.datasource.db1097identity.username=${DATABASE_IDENTITY_USERNAME}
spring.datasource.db1097identity.password=${DATABASE_IDENTITY_PASSWORD}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n src/main/environment/common_docker.properties

Repository: PSMRI/AMRIT-DB

Length of output: 1349


🏁 Script executed:

rg "DATABASE_1097|DATABASE_IDENTITY" --type properties

Repository: PSMRI/AMRIT-DB

Length of output: 92


🏁 Script executed:

rg "db1097identity|dbidentity|dbiemr|dbreporting" --type properties -A 2 -B 1

Repository: PSMRI/AMRIT-DB

Length of output: 92


🏁 Script executed:

rg "DATABASE_1097_IDENTITY" -g "*.properties" -g "*.yml" -g "*.yaml" -g "*.env*"

Repository: PSMRI/AMRIT-DB

Length of output: 292


🏁 Script executed:

rg "DATABASE_IDENTITY_USERNAME|DATABASE_IDENTITY_PASSWORD" -g "*.properties" -g "*.yml" -g "*.yaml" -g "*.env*" -g "*.java" -B 2 -A 1

Repository: PSMRI/AMRIT-DB

Length of output: 2146


🏁 Script executed:

rg "db1097identity" -g "*.java" -g "*.properties" -g "*.yml" -B 2 -A 2

Repository: PSMRI/AMRIT-DB

Length of output: 6086


Fix db1097identity credential environment variables.

Lines 21–22 incorrectly reference DATABASE_IDENTITY_USERNAME and DATABASE_IDENTITY_PASSWORD. The JDBC URL on line 20 uses DATABASE_1097_IDENTITY_URL, so the credentials should use a matching 1097-specific prefix: DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD. This inconsistency causes db1097identity to share credentials with the separate dbidentity datasource, risking authentication failure or credential mismatch in production.

Current configuration (lines 20–22)
spring.datasource.db1097identity.jdbc-url=${DATABASE_1097_IDENTITY_URL}
spring.datasource.db1097identity.username=${DATABASE_IDENTITY_USERNAME}
spring.datasource.db1097identity.password=${DATABASE_IDENTITY_PASSWORD}
🤖 Prompt for AI Agents
In `@src/main/environment/common_docker.properties` around lines 20 - 22, The
db1097identity datasource properties use the wrong environment variable names
for credentials; change the values for spring.datasource.db1097identity.username
and spring.datasource.db1097identity.password to reference
DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD respectively
so they match the JDBC URL (DATABASE_1097_IDENTITY_URL) and keep db1097identity
credentials isolated from the generic dbidentity variables.

@drtechie drtechie merged commit d55498f into main Feb 5, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant