Conversation
📝 WalkthroughWalkthroughA new properties file is introduced containing Spring Boot datasource configurations for Docker environments. The file defines multiple datasources with environment variable references for connection URLs, usernames, and passwords, all using MySQL JDBC drivers. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
@sac2kadam I am merging this in interest of time. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/main/environment/common_docker.properties`:
- Around line 20-22: The db1097identity datasource properties use the wrong
environment variable names for credentials; change the values for
spring.datasource.db1097identity.username and
spring.datasource.db1097identity.password to reference
DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD respectively
so they match the JDBC URL (DATABASE_1097_IDENTITY_URL) and keep db1097identity
credentials isolated from the generic dbidentity variables.
| spring.datasource.db1097identity.jdbc-url=${DATABASE_1097_IDENTITY_URL} | ||
| spring.datasource.db1097identity.username=${DATABASE_IDENTITY_USERNAME} | ||
| spring.datasource.db1097identity.password=${DATABASE_IDENTITY_PASSWORD} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n src/main/environment/common_docker.propertiesRepository: PSMRI/AMRIT-DB
Length of output: 1349
🏁 Script executed:
rg "DATABASE_1097|DATABASE_IDENTITY" --type propertiesRepository: PSMRI/AMRIT-DB
Length of output: 92
🏁 Script executed:
rg "db1097identity|dbidentity|dbiemr|dbreporting" --type properties -A 2 -B 1Repository: PSMRI/AMRIT-DB
Length of output: 92
🏁 Script executed:
rg "DATABASE_1097_IDENTITY" -g "*.properties" -g "*.yml" -g "*.yaml" -g "*.env*"Repository: PSMRI/AMRIT-DB
Length of output: 292
🏁 Script executed:
rg "DATABASE_IDENTITY_USERNAME|DATABASE_IDENTITY_PASSWORD" -g "*.properties" -g "*.yml" -g "*.yaml" -g "*.env*" -g "*.java" -B 2 -A 1Repository: PSMRI/AMRIT-DB
Length of output: 2146
🏁 Script executed:
rg "db1097identity" -g "*.java" -g "*.properties" -g "*.yml" -B 2 -A 2Repository: PSMRI/AMRIT-DB
Length of output: 6086
Fix db1097identity credential environment variables.
Lines 21–22 incorrectly reference DATABASE_IDENTITY_USERNAME and DATABASE_IDENTITY_PASSWORD. The JDBC URL on line 20 uses DATABASE_1097_IDENTITY_URL, so the credentials should use a matching 1097-specific prefix: DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD. This inconsistency causes db1097identity to share credentials with the separate dbidentity datasource, risking authentication failure or credential mismatch in production.
Current configuration (lines 20–22)
spring.datasource.db1097identity.jdbc-url=${DATABASE_1097_IDENTITY_URL}
spring.datasource.db1097identity.username=${DATABASE_IDENTITY_USERNAME}
spring.datasource.db1097identity.password=${DATABASE_IDENTITY_PASSWORD}
🤖 Prompt for AI Agents
In `@src/main/environment/common_docker.properties` around lines 20 - 22, The
db1097identity datasource properties use the wrong environment variable names
for credentials; change the values for spring.datasource.db1097identity.username
and spring.datasource.db1097identity.password to reference
DATABASE_1097_IDENTITY_USERNAME and DATABASE_1097_IDENTITY_PASSWORD respectively
so they match the JDBC URL (DATABASE_1097_IDENTITY_URL) and keep db1097identity
credentials isolated from the generic dbidentity variables.



📋 Description
JIRA ID: AMM-2164
Add properties file for UNIX deployments.
✅ Type of Change
Summary by CodeRabbit