feat(specs): Add spec, tests and examples for panos_mfa_server_profile#684
Open
kklimonda-cl wants to merge 1 commit intomainfrom
Open
feat(specs): Add spec, tests and examples for panos_mfa_server_profile#684kklimonda-cl wants to merge 1 commit intomainfrom
kklimonda-cl wants to merge 1 commit intomainfrom
Conversation
413108e to
6008581
Compare
f64683e to
6008581
Compare
7ee4a1c to
64c5811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MFA Server Profile Resource
Terraform Resource Name
panos_mfa_server_profile
Resource Variants
Supported Locations
Parameters
Parameters with Codegen Overrides
Standard Parameters
Custom Validation
This resource includes custom validation logic (custom_validation: true) implemented in ValidateConfigCustom:
Vendor-Specific Configuration Validation
The custom validator enforces strict vendor-specific configuration requirements for four supported MFA vendors:
- duo-api-host
- duo-integration-key
- duo-secret-key
- duo-timeout
- duo-baseuri
- okta-api-host
- okta-baseuri
- okta-token
- okta-org
- okta-timeout
- ping-api-host
- ping-baseuri
- ping-token
- ping-org-alias
- ping-timeout
- rsa-api-host
- rsa-baseuri
- rsa-accesskey
- rsa-accessid
- rsa-assurancepolicyid
- rsa-timeout
Validation Rules
The custom validator performs the following checks at plan time:
This validation is needed because when valid mfa-vendor-type is used, PAN-OS device will return some of those list values even if they were not sent, creating inconsistency between plan and final value. By creating this validation we are enforcing that all values must be set by the user. This does mean we do not allow any defaults to be set by PAN-OS device, but that probably can't work with the way schema is defined.