Compatibility with CK3 1.18, Invictus 1.7 and Invictus 1.11 #2820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES - Modified removable/replaceable_files_blocks to get no errors on conversion (there is still more to add to it that was added in AUH, but there are at least no errors for now) - Added a check to make sure faiths have a theism doctrine (adding polytheism as a fallback if they don't) - Added new Baiyue, Mohism, and Shenic faiths - Redid and organized `religion_map.txt` for most of the Terra-Indomita religions so it is easier to read and hopefully have the proper faiths get chosen - Added new Dongyi, Baiyue, and Bashu cultures - Redid and organized `culture_map.txt` for most of the Terra-Indomita cultures so it is easier to read and hopefully have the proper cultures get chosen - Added culture House COA frames to converter cultures - Modified the following base game cultures: - Made `tujia` have Lolo Heritage (new heritage alongside Bashu), and its own language - Made `bai` have Lolo Heritage (new heritage alongside Bashu), and its own language - Made `yi` have Lolo Heritage (new heritage alongside Bashu), and its own language - Added some heritage empire mappings for new heritages and empire titles - Added some title mappings for the Korean kingdom titles to ones that made sense (will still likely need to add a new decision that allows Silla/Baekje/Goguryeo to be formed by their relevant cultures, or modify the "Unite Husamguk" decision to not require those titles) - Changed some of the references of `e_western_roman_empire` to `h_western_roman_empire` to get ready for those changes
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
changed the title
- Updated removable/replaceable_file_blocks.txt for up to CK3 1.18.3 (just to get rid of converter errors, there might still be things that should be changed later) - Modified CK3/Titles/Titles.cs so that succession laws properly get setup for the other admin government types too. - Added a decision to form Japan if it has no de jure land - Generalized a lot of the Ritsuryo/Soryo content to better work with any realm, not just e_japan - Added a game rule to determine if any ritsuryo empire should be given e_japan at game start - Added a game start effect so that ritsuryo empires properly get setup with ceremonial liege titles at game start - Renamed 'IRToCK3_titles_game_start.txt.liquid' to 'IRToCK3_on_actions.txt.liquid' - Renamed 'CONVERTER_title_holders.txt' to 'zz_CONVERTER_title_holders.txt' to better make sure its entries overwrite other mods/base game - Added a new event that triggers if you have multiple empire titles while one has a ceremonial liege associated with it to warn you of the issues that could cause - Added a new event that triggers when a ritsuryo empire first gets setup to explain a few of the changes that happened regarding the ceremonial liege - Modified government_map.txt so that only Terra-Indomita's 'yamato_empire' government maps to Ritsuryo. Japanese-cultured monarchies instead map to Soryo - Modified succession_law_map.liquid so that if you have Terra-Indomita's 'yamato_empire' or 'chinese_empire' governments, you will almost always get Primogeniture in CK3 - Modified title_map.txt to comment out Jomon (AIU) mapping to k_hitakami, since Jomon in Terra-Indomita seems like it better represents an island-wide, culturally-unified tag, not just the region of hitakami
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ImperatorToCK3/Data_Files/blankMod/output/common/on_action/IRToCK3_on_actions.txt.liquid
Show resolved
Hide resolved
ImperatorToCK3/Data_Files/blankMod/output/common/on_action/IRToCK3_on_actions.txt.liquid
Show resolved
Hide resolved
ImperatorToCK3/Data_Files/blankMod/output/events/government_events/irtock3_ritsuryo_events.txt
Outdated
Show resolved
Hide resolved
ImperatorToCK3/Data_Files/blankMod/output/localization/french/CONVERTER_game_rules_l_french.yml
Show resolved
Hide resolved
ImperatorToCK3/Data_Files/blankMod/output/localization/french/CONVERTER_game_rules_l_french.yml
Show resolved
Hide resolved
|
@IhateTrains I've opened a new pull request, #2898, to work on those changes. Once the pull request is ready, I'll request review from you. |
Addresses review feedback from #2820 to correct a misspelling in a comment. ## Changes - Fixed typo in `irtock3_scripted_effects.txt` line 1842: `SUCCESION` → `SUCCESSION` ```diff -# SETUP REGENCY SUCCESION +# SETUP REGENCY SUCCESSION ``` <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/ParadoxGameConverters/ImperatorToCK3/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IhateTrains <29546927+IhateTrains@users.noreply.github.com>
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
|
@IhateTrains I've opened a new pull request, #2899, to work on those changes. Once the pull request is ready, I'll request review from you. |
Corrects two instances of `mulitply` → `multiply` in the ritsuryo government events file, addressing reviewdog findings from #2820. ### Changes - Fixed line 365: `mulitply` → `multiply` in vassal military power calculation - Fixed line 404: `mulitply` → `multiply` in liege military power calculation Both misspellings were in similar percent difference calculations within modifier blocks. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: IhateTrains <29546927+IhateTrains@users.noreply.github.com>
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
IhateTrains
changed the title
IhateTrains
temporarily deployed
to
Build Environment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2784
closes #2799
closes #2862