Skip to content

SIP180 Add N gain from fixation#196

Draft
mswilburn wants to merge 2 commits intomasterfrom
SIP180-Add-N-gain-from-fixation
Draft

SIP180 Add N gain from fixation#196
mswilburn wants to merge 2 commits intomasterfrom
SIP180-Add-N-gain-from-fixation

Conversation

@mswilburn
Copy link
Contributor

No description provided.

@github-actions
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v19.1.1) reports: 1 file(s) not formatted
  • src/sipnet/sipnet.c

Have any feedback or feature suggestions? Share it here.

@dlebauer
Copy link
Member

dlebauer commented Dec 3, 2025

@mswilburn I've merged the new N-fixation scheme from #193; you can find it in the N-fixation and N-Demand sections https://pecanproject.github.io/sipnet/model-structure/#fraknitrogen-fixation-fn_textfix


Logically I think N fixation needs to be handled before N limitation, i.e. the sequence should be:

  • calculate N demand
  • calculate N_fix
  • re-calculate N demand
  • calculate N update
  • calculate N limitation & apply effects on growth

N fixation is designed to satisfy plant N demand - it adds directly to plant N and doesn't add to the N min pool (the next level of complexity would be to represent free-living n-fixers by allowing some or all fixed n to be added to N_min.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants