Add workflow to publish image on GitHub Container Registry#12
Open
Cubxity wants to merge 3 commits intoPeterDaveHello:masterfrom
Open
Add workflow to publish image on GitHub Container Registry#12Cubxity wants to merge 3 commits intoPeterDaveHello:masterfrom
Cubxity wants to merge 3 commits intoPeterDaveHello:masterfrom
Conversation
Author
|
@PeterDaveHello please review this PR ^ |
Owner
|
@Cubxity cool, I'll take a look, thanks! |
| push: | ||
| branches: [ "master" ] | ||
| schedule: | ||
| - cron: 0 0 * * * # Every day |
Owner
There was a problem hiding this comment.
Every weekend would be good enough I think, the upstream doesn't update so frequently.
PeterDaveHello
changed the title
| platforms: linux/amd64,linux/arm64 | ||
| tags: ghcr.io/${{ steps.vars.outputs.repository }}:latest | ||
| build-args: | | ||
| MAXMIND_LICENSE_KEY=${{ secrets.MAXMIND_LICENSE_KEY }} No newline at end of file |
Owner
There was a problem hiding this comment.
Let's add the missing newline char at the last line, thanks.
Owner
PeterDaveHello
left a comment
PeterDaveHello
left a comment
There was a problem hiding this comment.
@Cubxity thanks for your contribution, as I'm already using Travis CI here, I wonder maybe it's easier to maintain only one workflow tool, can you integrate the flow here to .travis.yml? Thank you.
Owner
|
@Cubxity not sure if you'd like to continue contribute to this PR? I'll like to get it merged ;) |
|
Will you continue, @Cubxity? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a workflow to publish image on GitHub Container Registry on push to master and on a daily schedule. This requires the secret
MAXMIND_LICENSE_KEYto be set in the repository.Resolves #7