Skip to content

Comments

chore: fail CI if 'pnpm run build:examples' fails#1170

Merged
louisgv merged 6 commits intomainfrom
chore/fix-ci-exitcode
Feb 9, 2025
Merged

chore: fail CI if 'pnpm run build:examples' fails#1170
louisgv merged 6 commits intomainfrom
chore/fix-ci-exitcode

Conversation

@pippinmole
Copy link
Collaborator

@pippinmole pippinmole commented Feb 9, 2025

Details

This PR makes sure the CI fails if a package fails to build. Currently, we are seeing examples fail to build, but the CI passes anyway 👎

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@pippinmole
Copy link
Collaborator Author

pippinmole commented Feb 9, 2025

@louisgv I think the issue lies with how @plasmohq/parcel-core handles the bundling. If one of the examples errors while building (and emits a non-zero error code), Parcel needs to propagate this up once again.

image

It shouldn't log 🟢 DONE | Finished in 3549ms!. Problem lines might be these: https://github.com/PlasmoHQ/plasmo/blob/main/cli/plasmo/src/commands/build.ts#L44. We might need to check if the result was successful, if not, exit and propagate error code.

@pippinmole pippinmole requested a review from louisgv February 9, 2025 22:10
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit ddcb655 into main Feb 9, 2025
1 check failed
@louisgv louisgv deleted the chore/fix-ci-exitcode branch February 9, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants