Skip to content

Comments

chore: replace ssh urls with https urls in .gitmodules#1171

Merged
louisgv merged 3 commits intomainfrom
chore/https-submodules
Feb 10, 2025
Merged

chore: replace ssh urls with https urls in .gitmodules#1171
louisgv merged 3 commits intomainfrom
chore/https-submodules

Conversation

@pippinmole
Copy link
Collaborator

@pippinmole pippinmole commented Feb 9, 2025

Details

This PR replaces all .gitmodule entries with HTTPS urls instead of SSH urls. This is because there is an issue with Renovate when cloning submodules using ssh, even if they're public.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

@pippinmole pippinmole requested a review from louisgv February 9, 2025 17:19
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 5e3691d Feb 10, 2025
1 check passed
@louisgv louisgv deleted the chore/https-submodules branch February 10, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants