Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| expected := "md5" + outerHex | ||
| return clientResponse == expected | ||
| } |
Check failure
Code scanning / CodeQL
Use of a broken or weak cryptographic hashing algorithm on sensitive data High
Implements PostgreSQL MD5 password authentication as an alternative to
cleartext (both protected by TLS):
- New AuthMethod config field ("cleartext" default, "md5")
- writeAuthMD5Password sends 4-byte random salt to client
- verifyMD5Password validates md5(md5(password + username) + salt)
- DUCKGRES_AUTH_METHOD env var and auth_method YAML config support
- Cleartext remains default for backwards compatibility
The MD5 auth flow:
1. Server generates random salt, sends AuthenticationMD5Password
2. Client computes "md5" + md5(md5(password+username) + salt)
3. Server verifies the hash matches
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
EDsCODE
force-pushed
the
feature/modern-auth
branch
from
402cdb0 to
3bc943f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
AuthMethodconfig type with "cleartext" (default) and "md5" optionswriteAuthMD5Password()to send 4-byte random saltverifyMD5Password()to validate MD5 hash responseauth_methodYAML config andDUCKGRES_AUTH_METHODenv varMD5 Auth Flow
"md5" + md5(md5(password + username) + salt)Configuration
Test plan
🤖 Generated with Claude Code