Skip to content

Implement server side disconnect packet#45

Open
PabloMK7 wants to merge 4 commits intoPretendoNetwork:masterfrom
PabloMK7:serverdc
Open

Implement server side disconnect packet#45
PabloMK7 wants to merge 4 commits intoPretendoNetwork:masterfrom
PabloMK7:serverdc

Conversation

@PabloMK7
Copy link
Contributor

Implements the method Disconnect in PRUDPEndPoint, which allows disconnecting a PRUDPConnection by sending it a DISCONNECT packet. The connection will be cleaned up after it times out or a disconnect acknowledgement packet is recieved back.

@PabloMK7 PabloMK7 requested a review from DaniElectra April 17, 2024 16:09
connection.cleanup()
pep.Connections.Delete(discriminator)

pep.emit("disconnect", disconnect)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this? We already have the "connection ended" event anyway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emit? What's it's purpose anyways?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of emit is to send event signals to listeners. We don't personally make use of all of them, but another developer may find them useful in their own servers (such as more detailed logging at the packet level). The syn, connect, disconnect and data events are emitted when packets of those types are received. Though looking at the code again, we only expose the disconnect and data packet events (in previous versions of the library the On method was exported and could be used to listen for any packet type, but this was removed in favor of specific OnData and OnDisconnect methods)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments