Pass stderr through calc_install_files when commands fail#709
Open
JasonGross wants to merge 2 commits intoPrincetonUniversity:masterfrom
Open
Pass stderr through calc_install_files when commands fail#709JasonGross wants to merge 2 commits intoPrincetonUniversity:masterfrom
JasonGross wants to merge 2 commits intoPrincetonUniversity:masterfrom
Conversation
Collaborator
|
I'm not sure about this. How about a version that does NOT run each command twice, but puts the standard error (or other info) in a log file, for later diagnosis if necessary? |
JasonGross
force-pushed
the
pass-stderr
branch
from
72c4839 to
e3da59b
Compare
Contributor
Author
|
That's a much better idea! I've stuck the info in |
JasonGross
force-pushed
the
pass-stderr
branch
from
e3da59b to
5db3b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how good an idea this is. It complicates the code a bit, but will probably make it easier to diagnose issues like #706 in the future