Added themes.json and some extras#92
Open
RunDevelopment wants to merge 2 commits intoPrismJS:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for prism#2175, I added a way to get 1) all themes and 2) the name of each theme. So I added a
themes.jsonwith that information.From here on it escalated a little.
Since
themes.jsonandREADME.mdboth contained that same information, I added the author info tothemes.jsonand made it so thatgulpnow generates the list of available themes fromthemes.json.With those changes, I updated the "Added a new theme" section in
README.mdand the section got quite long, so I moved it intoCONTRIBUTING.md.And since I already added a file specifically for information for contributors, I might as well include a few guidelines and requirements we have for themes to guarantee that they work with Prism and its plugins.
But now we have rules with no way to enforce them! So I added a new check to
gulpfile.jswhich using JSDom verifies that all themes fulfill all requirements.And guess what! One existing theme didn't fulfill a requirement, so I fixed it.
That's how we got here.
Features:
themes.jsonwhich contains basic information about all themes.