Simplify core (the rest of the changes from the simplify branch)#4029
Simplify core (the rest of the changes from the simplify branch)#4029DmitrySharabin merged 9 commits intov2from
simplify branch)#4029Conversation
✅ Deploy Preview for dev-prismjs-com ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Something weird is happening here: IDK why the tests fail. Locally, all the tests pass. Hm, I need to investigate it. UPDATE: Fixed! Anyway, it's a giant leap forward, since there are a few minor changes left in the |
Oh, I know why this happens. Locally, I have applied the changes from #4018. Therefore, the updated API leverages the new, more declarative language definitions. I'll update the PR's description to reflect that. |
222f845 to
dd0af79
Compare
The `autoloader` plugin is not loaded automatically.
We use the `CustomEvent` class, which [became stable in `v20.13`](https://nodejs.org/api/events.html#class-customevent).
Found after running the `regex-coverage` npm script.
Found after running the `regex-coverage` npm script.
dd0af79 to
26bf9fb
Compare
Depends on #4018.
Summary
Most of the code was authored by @LeaVerou.
bashandcss-selector(actually, we didn't have tests for it at all 🤷♂️)global.jsentry point to work with bare Prism (without theautoloaderplugin loaded automatically)We use the
CustomEventclass, which became stable inv20.13.Demo: https://codepen.io/dmitrysharabin/pen/qEbeEXv
This is part 1 of 2 in a stack made with GitButler:
$inside#4032simplifybranch) #4029 👈