Closed
Conversation
The cursor was jumping to the beginning of the comment field during input. This was caused by the `ContentEditable` component re-rendering on every keystroke, which reset the cursor position. This change introduces the `shouldComponentUpdate` lifecycle method to the `ContentEditable` component. This method prevents the component from re-rendering if the new `html` prop is the same as the component's current inner HTML, which is the case during user input. This ensures that the component does not re-render unnecessarily, preserving the cursor's position. Both `script.jsx` and the compiled `script.js` have been updated with this change.
Fix: Prevent cursor jump when typing in comments The cursor was jumping to the beginning of the comment field during input. This was caused by the `ContentEditable` component re-rendering on every keystroke, which reset the cursor position. This change introduces the `shouldComponentUpdate` lifecycle method to the `ContentEditable` component. This method prevents the component from re-rendering if the new `html` prop is the same as the component's current inner HTML, which is the case during user input. This ensures that the component does not re-render unnecessarily, preserving the cursor's position. Both `script.jsx` and the compiled `script.js` have been updated with this change.
Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com>
Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com>
Co-authored-by: ProLoser <67395+ProLoser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert repository to commit 209e620
Plan:
ContentEditablecomponent re-rendering on every keystroke, which reset the cursor position. This change introduces theshouldComponentUpdatelifecycle method to theContentEditablecomponent. This method prevents the component from re-rendering if the newhtmlprop is the same as the component's current inner HTML, which is the case during user input. This ensures that the component does not re-render unnecessarily, preserving the cursor's position. Bothscript.jsxand the compiledscript.jshave been updated with this change. #12 and Fix cursor jumping to beginning in ContentEditable inputs #14)Changes to revert:
placeCaretAtPositionfunction (34 lines)shouldComponentUpdatemethod from ContentEditable componentcomponentWillUpdatemethod from ContentEditable componentcomponentDidUpdatemethod from ContentEditable componentOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.