feat: add pass-device-specs flag for volcano-vgpu-device-plugin #104
Open
vcr1311 wants to merge 1 commit intoProject-HAMi:mainfrom
Open
feat: add pass-device-specs flag for volcano-vgpu-device-plugin #104vcr1311 wants to merge 1 commit intoProject-HAMi:mainfrom
vcr1311 wants to merge 1 commit intoProject-HAMi:mainfrom
Conversation
This commit adds support for the --pass-device-specs flag, enabling volcano-vgpu-device-plugin to work with standard OCI container runtimes (containerd, docker) that do not have nvidia-container-runtime installed. When enabled, the device plugin explicitly passes GPU device file paths to kubelet via the DeviceSpec field in ContainerAllocateResponse. Kubelet then mounts these devices (/dev/nvidia*, /dev/nvidiactl, /dev/nvidia-uvm, etc.) directly into containers, bypassing the need for nvidia-container-runtime. Changes: - Add --pass-device-specs command-line flag (default: false) - Add PassDeviceSpecs configuration variable in config package - Implement GetDeviceSpecs() helper method to build device specifications - Modify Allocate() method to populate response.Devices when flag is enabled - Support both regular GPU and MIG device paths - Handle control devices (/dev/nvidiactl, etc.) with existence checks This maintains full backward compatibility - when the flag is disabled (default), the plugin behaves exactly as before, relying on nvidia-container-runtime for device mounting. Signed-off-by: Vikash Rai <vikash.ingress@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vcr1311 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @vcr1311! It looks like this is your first PR to Project-HAMi/volcano-vgpu-device-plugin 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for the --pass-device-specs flag, enabling volcano-vgpu-device-plugin to work with standard OCI container runtimes (containerd, docker) that do not have nvidia-container-runtime installed.
When enabled, the device plugin explicitly passes GPU device file paths to kubelet via the DeviceSpec field in ContainerAllocateResponse. Kubelet then mounts these devices (/dev/nvidia*, /dev/nvidiactl, /dev/nvidia-uvm, etc.) directly into containers, bypassing the need for nvidia-container-runtime.
Changes:
This maintains full backward compatibility - when the flag is disabled (default), the plugin behaves exactly as before, relying on nvidia-container-runtime for device mounting.
Signed-off-by: Vikash Rai vikash.ingress@gmail.com