When close child size is 0, close() returned without changing#16
Open
howyi wants to merge 1 commit intoProseMirror:masterfrom
Open
When close child size is 0, close() returned without changing#16howyi wants to merge 1 commit intoProseMirror:masterfrom
howyi wants to merge 1 commit intoProseMirror:masterfrom
Conversation
Member
|
Would it be possible to add a test that fails with the current code but passes with this patch in test/test-trans.js? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: outline/rich-markdown-editor#233
https://github.com/outline/rich-markdown-editor/pull/252/files
3915231
After this commit(> 1.2.5), "setBlockType ()" of "prosemirror-command" has a problem.
This is a fix for the problem that Node's Wrap is not working as shown in the image.
Specifically, the line you intended to change is deleted, and the line below is changed.
current
fixed(in this commit)