Fix hasFocus() for editors nested in contenteditable elements#189
Open
excursus wants to merge 1 commit intoProseMirror:masterfrom
Open
Fix hasFocus() for editors nested in contenteditable elements#189excursus wants to merge 1 commit intoProseMirror:masterfrom
excursus wants to merge 1 commit intoProseMirror:masterfrom
Conversation
Member
Which browser does this? |
Author
|
I tested this in Chrome on OSX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a ProseMirror editor is nested inside another element with
contenteditable="true",view.hasFocus()incorrectly returnsfalseeven when the editor has focus. This causes various functionality to break, including selection handling.Cause
When the editor is inside a contenteditable ancestor, the browser sets
document.activeElementto the outermost contenteditable element rather than the editor's DOM element. The existinghasFocus()implementation comparesactiveElementdirectly tothis.dom, which fails in this nested scenario.Solution
Added an
effectiveActiveElement()helper method that accounts for nested contenteditable elements. WhenactiveElementis an ancestor that containsthis.dom, the helper returnsthis.domas the effective active element. ThehasFocus()method now uses this helper instead of directly accessingthis.root.activeElement.Testing
hasFocus()returns true when the editor is mounted inside a contenteditable wrapper